[RAC] [RBAC] force rule data client to register features #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e master list which maps feature id to index names
dhurley14
force-pushed
the
master_list_alerts_indices
branch
from
a5d5ff5 to
879c0c0
Compare
yctercero
reviewed
Jul 1, 2021
| @@ -46,6 +46,15 @@ interface GetAlertParams { | |||
| index?: string; | |||
| } | |||
|
|
|||
| export const validFeatureIds = ['apm', 'observability', 'siem'] as const; | |||
There was a problem hiding this comment.
How do we distinguish between observability and apm, etc. Is apm a subset of observability?
There was a problem hiding this comment.
Data grid should know where it is.. but yeah I think that's what observability is going for with their "top alerts" rule which looked to be querying .alerts..
jasonrhodes
suggested changes
Jul 1, 2021
| alias: plugins.ruleRegistry.ruleDataService.getFullAssetName(), | ||
| feature: 'observability', |
There was a problem hiding this comment.
What does listing the feature do here?
There was a problem hiding this comment.
The purpose of the feature param is to force the user to update the data structure which contains the mapping of consumers to alerts as data indices. The idea is it is typed such that it forces the user to go to the code and modify it. At least until a better system is put in place or we move the alerts as data client out of rule registry.
x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
Outdated
Show resolved
Hide resolved
dhurley14
force-pushed
the
master_list_alerts_indices
branch
from
f213f64 to
fbd3905
Compare
dhurley14
force-pushed
the
master_list_alerts_indices
branch
from
c4b7ace to
d2173f5
Compare
yctercero
pushed a commit
that referenced
this pull request
Jul 5, 2021
* force any plugin registering rules to register the feature id into the master list which maps feature id to index names * javascript is not python * favor keyof instead of typeof as const, removes ts-expect-error * updates typedocs * adds rbac utils to utils folder and updates typedocs * featureIds is already string[] and do not trust input for type guard
dhurley14
added a commit
that referenced
this pull request
Jul 7, 2021
* force any plugin registering rules to register the feature id into the master list which maps feature id to index names * javascript is not python * favor keyof instead of typeof as const, removes ts-expect-error * updates typedocs * adds rbac utils to utils folder and updates typedocs * featureIds is already string[] and do not trust input for type guard
dhurley14
added a commit
that referenced
this pull request
Jul 8, 2021
* force any plugin registering rules to register the feature id into the master list which maps feature id to index names * javascript is not python * favor keyof instead of typeof as const, removes ts-expect-error * updates typedocs * adds rbac utils to utils folder and updates typedocs * featureIds is already string[] and do not trust input for type guard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
force any plugin registering rules to register the feature id into the master list which maps feature id to index names
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers